search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.71k stars 928 forks source link

Twos grid should be a class #1668

Open Riksu9000 opened 1 year ago

Riksu9000 commented 1 year ago

Twos app code can be improved by making the grid a separate class with member functions that manipulate the grid, instead of everything being in the screen class.

rkmdCodes commented 1 year ago

hi @Riksu9000 , can u elaborate more about the issue

Riksu9000 commented 1 year ago

https://github.com/InfiniTimeOrg/InfiniTime/blob/main/src/displayapp/screens/Twos.cpp https://github.com/InfiniTimeOrg/InfiniTime/blob/main/src/displayapp/screens/Twos.h

Currently in the Screen derived class Twos there's a variable grid, and functions that manipulate the grid. It would be a good idea to move them into a new TwosGrid class for better organization and readability.