search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.71k stars 927 forks source link

Metronome: Dragging the arc will snap to 98 bpm #1685

Open Riksu9000 opened 1 year ago

Riksu9000 commented 1 year ago

Verification

What happened?

Dragging the arc will snap to 98 bpm

What should happen instead?

No response

Reproduction steps

This issue happens since this commit https://github.com/InfiniTimeOrg/InfiniTime/commit/5ef3c0d3be58b6741a9e443e6d2151de2b3a59bc.

More details?

In Metronome, we don't want the app to close while dragging the arc. This was previously accomplished by setting the return touch event to none, and handling the exiting in app, but there's currently no way to disable the default return touch event. Returning true in OnTouchEvent will cancel LVGL tap, which will move the cursor to {-1, -1}, which is at the top left corner of the screen, setting the bpm to 98. Returning false will allow DisplayApp to close the app if it detects an appropriate touch event.

Version

develop

Companion app

No response

minacode commented 1 year ago

What do you think about using the number choosing widget like in the time related apps? The arc looks good, but it is not very practical in general.

Riksu9000 commented 1 year ago

If there's a proposal that improves upon the current state of the app, we'll consider it, however this issue limits how we can use LVGL in general and should be fixed regardless.