Notifications: std::optional id

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS

GNU General Public License v3.0

2.64k stars 907 forks source link

Notifications: std::optional id #1713

Closed Riksu9000 closed 6 months ago

Riksu9000 commented 1 year ago

validDisplay is used to express when the screen is displaying a real notification, instead of displaying that there are no notifications. When it is not displaying a notification, the currentId is always invalid. Use std::optional to replace validDisplay and express that currentId may be invalid.

Set CXX standard to 17 to support std::optional.

github-actions[bot] commented 1 year ago

Build size and comparison to main:	Section	Size
text	406584B	96B
data	940B	0B
bss	53560B	0B