search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 907 forks source link

notifications: Dismiss to watchface when empty #1716

Open eliedrian opened 1 year ago

eliedrian commented 1 year ago

I found it slightly annoying that dismissing all notifications leaves me with a "No notification to display" message. Instead of dismissing to a relatively useless message, dismiss to watchface.

github-actions[bot] commented 1 year ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
eliedrian commented 1 year ago

Also addressed the strange animation.

Earlier, screen was flagged to be killed without the animation occurring.

eliedrian commented 1 year ago

Squashed.

Also updated the comment instead of fully removing it.

RageGamerBoi commented 1 year ago

Oh, thank you so much, I've been wanting a feature like this for so long!

mark9064 commented 8 months ago

Have been daily driving this for months, zero issues

mark9064 commented 2 months ago

Are there any outstanding issues preventing this from being merged? To me this is an easy usability improvement and as far as I can see all review comments have been addressed

eliedrian commented 1 month ago

Yes, anything lacking from this?