search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 904 forks source link

node: Add lv_font_conv to node package #1764

Open FintasticMan opened 1 year ago

FintasticMan commented 1 year ago

This means that these can be installed by simply running npm i.

github-actions[bot] commented 1 year ago
Build size and comparison to main: Section Size Difference
text 376784B -16B
data 940B 0B
bss 63420B 0B
NeroBurner commented 1 year ago

If we just need to do npm install, then we could simplify the workflow a bit. Could you update those files in .github as well?

FintasticMan commented 1 year ago

If we just need to do npm install, then we could simplify the workflow a bit. Could you update those files in .github as well?

I've just done this, by installing the packages in the InfiniTime directory, and telling InfiniSim to also search there for the binaries.

I've also updated the docker image to install the npm packages in the InfiniTime directory.

NeroBurner commented 1 year ago

But it would require me to have a working internet connection for each build. Previously that was a requirement for just the docker image creation

I think you could use a COPY packages.json command and delete it after the npm command again -- Sent from my Android device with K-9 Mail. Please excuse my brevity.

mark9064 commented 7 months ago

Might want to remove image conv from the title of the PR to clarify that it's no longer used, I was a bit confused at first

FintasticMan commented 7 months ago

Oh yeah, forgot to do that.