search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 904 forks source link

Remove the vibration while charging #1768

Open minacode opened 1 year ago

minacode commented 1 year ago

This fixes #724 where the vibration interupts the physical connection with the charger and therefore triggers a new charging event and vibration, ending in a cycle of vibrations while charging.

github-actions[bot] commented 1 year ago
Build size and comparison to main: Section Size Difference
text 369768B -16B
data 940B 0B
bss 63516B 0B
Itai-Nelken commented 1 year ago

I like this, I have experienced this problem many times. But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?

minacode commented 1 year ago

I like this, I have experienced this problem many times.

Nice :) It seems to be a common issue.

But I would still like some way to be sure the watch is charging other than the tiny icon that is hard to see. Maybe the battery settings page opens when charging?

I think that would belong to another PR. This one is only about removing the bug.

everypizza1 commented 11 months ago

That's not a problem I have had on the sealed watch, but the vibration is very loud.

mark9064 commented 8 months ago

Just FYI there is also #1876

minacode commented 8 months ago

Which I like even more! 😄 I hope your gets merged. We can close this one if it did.

RageGamerBoi commented 7 months ago

I do like the tactility though, what about only doing the vibration if there hasn’t been a charging event in the last ~1 minute?

minacode commented 5 months ago

I will keep this PR as simple as possible and just remove the one line.