InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.76k stars 944 forks source link

GadgetBridge 0.53.0's Music Integration doesn't seem working with InfiniTime 0.13.0 #180

Closed SolAstri closed 3 years ago

SolAstri commented 3 years ago

I've updated my PineTime today, it was working previously on 0.10.0, but is broken now.

Avamander commented 3 years ago

Not an InfiniTime issue, Gadgetbridge needs an update.

SolAstri commented 3 years ago

Will it work in the next GB's release then? And does it work now, if I'll compile it by myself?

Avamander commented 3 years ago

@DanielSolmann Depends on how fast the change is made on GB's side and if it's done before or after the next release.

JF002 commented 3 years ago

Yes, we changed the UUIDs of the BLE services for more coherency and, by doing this, we broke the music service implemented in Gadgetbridge and Amazfish. The last version of amazfish is already up to date, but I don't think anyone has already done the change in Gadgetbridge. I won't have the time to do it in the near future so I hope someone will do it for us :)

vbelloir commented 3 years ago

With which version of Amazfish is it supposed to work?

With Infinitime 0.1.00, and amazfish 1.9.0, music integration is broken for me

stephanlachnit commented 3 years ago

I opened an issue for Gadgetbridge here: https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/2199

stephanlachnit commented 3 years ago

Fixed in https://codeberg.org/Freeyourgadget/Gadgetbridge/commit/b9647e26c3287053e88330ebc97ed25fafe29d7e

ncartron commented 3 years ago

With which version of Amazfish is it supposed to work?

With Infinitime 0.1.00, and amazfish 1.9.0, music integration is broken for me

@vbelloir I believe you had the answer in the meantime, but just for tracking purposes in that issue: the version of Amazfish wihch fixes that is 1.9.5

vbelloir commented 3 years ago

With which version of Amazfish is it supposed to work? With Infinitime 0.1.00, and amazfish 1.9.0, music integration is broken for me

@vbelloir I believe you had the answer in the meantime, but just for tracking purposes in that issue: the version of Amazfish wihch fixes that is 1.9.5

Well, not exactly. It's in 1.9.1 that music app is working. But this version wasn't release in openrepos for SFOS.

ncartron commented 3 years ago

right, I forgot to mention that I was pointing to the downloadable version of Amazfish for SFOS :)

JF002 commented 3 years ago

@stephanlachnit Thank you very much for your work on Gadgetbridge :100: ! I was also missing the music integration since we've changed the UUIDs !

stephanlachnit commented 3 years ago

@JF002 can you check the UUIDs or if it the latest Gadgetbridge works for you? Still doesn't work for me :/

stephanlachnit commented 3 years ago

Nvm I'm stupid, I didn't look at https://github.com/JF002/Pinetime/commit/ba03372f3b99798de2ce497d34f9ee5697e3be40, only https://github.com/JF002/Pinetime/commit/ccbe2e8e1b15a09b4d9e51b54a5a2e4cdb847fdc. New PR incoming. Edit: https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/2206

JF002 commented 3 years ago

Fixed in Gadgetbridge 0.55