PTS: Add setting to display temperature in Fahrenheit

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS

GNU General Public License v3.0

2.64k stars 904 forks source link

PTS: Add setting to display temperature in Fahrenheit #1805

Closed FintasticMan closed 6 months ago

FintasticMan commented 11 months ago

This adds a "weather format" setting, which can be either Metric or Imperial.

Fixes #1783.

@kieranc does this look good to you?

github-actions[bot] commented 11 months ago

Build size and comparison to main:	Section	Size
text	369544B	544B
data	940B	0B
bss	63516B	0B

JF002 commented 6 months ago

@FintasticMan Thanks for this PR! I usually refrain from adding new settings but I think we cannot avoid this one : the world use 2 units to measure the temperature, we need to adapt :-)

Would you like to port those changes to the new Simple Weather Service implementation (https://github.com/InfiniTimeOrg/InfiniTime/pull/1924) ? We'll probably merge it soon.

FintasticMan commented 6 months ago

Yes, I'll rebase this onto #1924 👍