search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 903 forks source link

Music: Replace placeholder text #1841

Open Commenter25 opened 10 months ago

Commenter25 commented 10 months ago

When starting the Music app, you can see a flash of the placeholder developer text that appears.

A video showing entering and exiting the music app, and the flash of placeholder text when entering

In some cases, the placeholder can actually stay. It appears to be when a companion app is connected but no music data is available.

This simply changes the placeholder text to the waiting text, to prevent that extra flash changing from the placeholder to the waiting state.

In the case where the placeholder stays, I also found that it will change to 00:00/00:00, rather than --:--/--:--. This is a similar unnecessary flash of text, so when the total length is zero, it will show dashes instead.

github-actions[bot] commented 10 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
FintasticMan commented 10 months ago

It would be good to get rid of the placeholder text, but the way this is done means that the "Waiting for" and "track information.." strings are duplicated. I'd rather avoid that.

Commenter25 commented 10 months ago

Very understandable. I've moved the repeated strings into variables. The text was removed from MusicService. In my opinion, it makes more sense for the generalized service to simply return nothing when there is nothing, and have the UI handle that. Currently it appears to be only used for the music app anyway, but any new implementations might benefit, like a watch face that shows the current song.

Instead, if the total duration is zero, it will draw the waiting text. This way, it can't show a partial placeholder; and when a companion app sends empty data, the waiting text will reappear. Previously, it was possible for it to say "Waiting for [track name]", and blank data would show nothing until the app restarts.

I must admit, my C++ knowledge is limited (non-existent), but I've tried my hand anyway. Hopefully not too poorly, it at least works in my testing, but if I did something wrong lemme know.