search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 903 forks source link

Adds scroll bar to music app #1875

Open SteveAmor opened 9 months ago

SteveAmor commented 9 months ago

Fixes #1391

github-actions[bot] commented 9 months ago
Build size and comparison to main: Section Size Difference
text 376848B 64B
data 940B 0B
bss 63420B 0B
SteveAmor commented 9 months ago

InfiniSim_2023-10-04_202308

minacode commented 9 months ago

I imagine it could look a little better with a little margin around the buttons. What do you think?

SteveAmor commented 9 months ago

The page indicator is 2px wide. However, if I move the buttons 3px, it conveniently has a 3px space between the play/pause button too, making it nice and symmetrical. What do people think?

InfiniSim_2023-10-05_080028

For comparison, here are the buttons moved 2px

2px

minacode commented 9 months ago

I like the first image where the bar is not touching the button.

SteveAmor commented 9 months ago

PR updated to move the buttons 3px.

SteveAmor commented 9 months ago

I experimented with hiding or deleting the page indicator object when you switch pages. According to the simulator, hiding the object used more lvgl memory than deleting and creating. So I went with deleting. I guess it used more memory as you actually had more objects at any one time, with one of them hidden.