search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 903 forks source link

Show alarm controller state in status icons #1884

Open jmlich opened 8 months ago

jmlich commented 8 months ago

I would like to know if the alarm is active on Watch Face Digital screen.

I made an prototype with InfiniSim and it looks that it works as expected:

InfiniSim_2023-10-08_113731 infinisim

However, I have only sealed version of PineTime and this is my first attempt to make something for embedded device. I will be happy if someone can check if this actually works on real device. I am looking forward for your feedback.

github-actions[bot] commented 8 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
jmlich commented 8 months ago

I have also tested the feature on hardware.

RageGamerBoi commented 7 months ago

I like this, but I think the icon has a little too much filled space and the simple circle isn’t as defined as a more standard alarm icon:

image

Of course these might not work with a resolution that small, but I’m sure something similar could…

jmlich commented 7 months ago

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.

RageGamerBoi commented 7 months ago

Ah, I forgot it was already the icon for the alarm app. Sorry about that.

On November 9, 2023 9:30:26 AM CST, Jozef Mlich @.***> wrote:

I wasn't trying to replace clock icon. I was trying to provide an information about alarm status with existing icon.

I agree that rework of icons and design overall may improve look and feel, but this wasn't my intention in this pull request.

-- Reply to this email directly or view it on GitHub: https://github.com/InfiniTimeOrg/InfiniTime/pull/1884#issuecomment-1804051536 You are receiving this because you commented.

Message ID: @.***>

vkareh commented 4 months ago

This should be rebased against main and updated to reflect the new icon from https://github.com/InfiniTimeOrg/InfiniTime/pull/1996