Setting to disable DFU and FS access

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS

GNU General Public License v3.0

2.64k stars 902 forks source link

Setting to disable DFU and FS access #1891

Open DavisNT opened 8 months ago

DavisNT commented 8 months ago

This PR adds setting to disable firmware update and Bluetooth file transfer. This is 2. part for https://github.com/InfiniTimeOrg/InfiniTime/issues/1814#issuecomment-1763740314

github-actions[bot] commented 8 months ago

Build checks have not completed. Possible reasons for this are:

The checks need to be approved by a maintainer
The branch has conflicts
The firmware build has failed

DavisNT commented 8 months ago

Both issues discovered by the workflows should now be fixed.

I have force-pushed fix for the formatting error in SettingOTA.cpp.
For InfiniSim I have created https://github.com/InfiniTimeOrg/InfiniSim/pull/125 Building this PR with InfiniSim PR should fix the InfiniSim build issue.

DavisNT commented 8 months ago

The build-simulator step is expected to fail, because it needs https://github.com/InfiniTimeOrg/InfiniSim/pull/125

DavisNT commented 8 months ago

Made two improvements:

Added branch prediction hints, to minimize performance impact during real data transfer
Return BLE_ATT_ERR_INSUFFICIENT_RES when access is not allowed

Could it be possible to review this PR?

DavisNT commented 8 months ago

Rebased as well.

DavisNT commented 6 days ago

Is this PR (and the other PR described in https://github.com/InfiniTimeOrg/InfiniTime/issues/1814#issuecomment-1763740314 ) welcome? If I will rebase and adjust this PR to work with the latest changes, will it be merged? @JF002, @FintasticMan, @Avamander Any feedback from project maintainers would be appreciated.

DavisNT commented 10 hours ago

Rebased (against main) and adjusted this PR. And done a few tests on my PineTime.

If there are questions about b2e2690adfbc13cbf4e0778a428baa6b11b35fba please see branch https://github.com/DavisNT/InfiniTime/tree/otaset-oom - this branch has the memory saving as the last commit (trying to build otaset-oom without last commit should cause the build to fail with /opt/gcc-arm-none-eabi-10.3-2021.10/bin/../lib/gcc/arm-none-eabi/10.3.1/../../../../arm-none-eabi/bin/ld: region RAM overflowed with stack).