search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 902 forks source link

Music app redesign #1901

Open coffandro opened 8 months ago

coffandro commented 8 months ago

I found the stock music app unsatisfactory so therefor I decided to redesign it, on my watch I've found it to be more stable than stock and it's easier to see what buttons do and such image

github-actions[bot] commented 8 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
RageGamerBoi commented 7 months ago

This is great, it improves accessibility of the volume icons and is a better overall solution than #1875 . It does have some minor issues (the title might need a better way to fit on screen) but I think those can be fixed. I hope this gets merged :)

coffandro commented 7 months ago

Thank you, I 100% agree, also wanted to somehow make the title more or less fill the entire empty space but couldn't find a way to do it in LGVL

coffandro commented 7 months ago

Newest version provides a better layout for the song name though it does have a tendency to overflow slightly which I'm working on

JustScott commented 5 months ago

Loving this design! I noticed that swiping up and down increases and decreases the volume, removing the ability to swipe down to exit the app. I'm not sure if this was intentional or a bug, but assuming it was intentional, I think the Infinitime developers prefer apps to not take over the swipe to exit ability (I think I saw someone say that in a PR, I may also be wrong). Anyways... I'll still be using it, thank you for the work you did on this!

JustScott commented 5 months ago

@coffandro I noticed you changed the notification label color in this pull request, as that's unrelated to the music app it should probably be removed.

coffandro commented 5 months ago

That is true, updating it in a day or so for 1.14 and ill remove it and recheck everything then

coffandro commented 5 months ago

Loving this design! I noticed that swiping up and down increases and decreases the volume, removing the ability to swipe down to exit the app. I'm not sure if this was intentional or a bug, but assuming it was intentional, I think the Infinitime developers prefer apps to not take over the swipe to exit ability (I think I saw someone say that in a PR, I may also be wrong). Anyways... I'll still be using it, thank you for the work you did on this!

Pretty sure the stock music app already lock up/down, i have just adapted it for my own use case, and the one i see as more practical, where the music app "takes over" control until you press the button, can remove this if a maintainer wants me to tho

JustScott commented 5 months ago

That is true, updating it in a day or so for 1.14 and ill remove it and recheck everything then

I just adapted it to 1.14 so i could merge it into my fork, you can use it if you'd like! https://github.com/JustScott/InfiniTime/tree/change_music_app_design