search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.64k stars 902 forks source link

Watch face selection using CMake #1934

Closed JF002 closed 5 months ago

JF002 commented 6 months ago

The list of watch face to build into the firmware is now set by CMake (-DENABLE_WATCHFACES).

Fix SettingWatchFace : convert to index to/from WatchFace when needed.

github-actions[bot] commented 6 months ago
Build size and comparison to main: Section Size Difference
text 369768B 208B
data 940B 0B
bss 63516B 0B
vkareh commented 5 months ago

This works well for me (I rebased this locally against main). Disabling some of the faces I'm not personally interested in shaved off 23K from my image file as compared to main. That's a huge deal :)

JF002 commented 5 months ago

@vkareh Thanks for the feedback! That was exactly the goal of those changes :+1

@NeroBurner Thanks for the review, I applied all your suggestions !