search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.63k stars 902 forks source link

WatchFaceAnalog: Use status icons class #1963

Closed vkareh closed 5 months ago

vkareh commented 5 months ago

Instead of recreating the status icons for BLE and battery, we can reuse the StatusIcon class to automatically display them.

vkareh commented 5 months ago

This doesn't change any functionality, it just reuses the existing StatusIcon class rather than duplicate its code in the Analog face.

github-actions[bot] commented 5 months ago
Build size and comparison to main: Section Size Difference
text 369448B -336B
data 940B 0B
bss 63516B 0B
FintasticMan commented 5 months ago

This has been discussed before, but I'm willing to discuss it further: #1336.

vkareh commented 5 months ago

@FintasticMan ah, I see the point. I wasn't aware of that discussion, but it makes sense with regards to the display overlap. It feels like a useful widget, the status icons, but it's being used only in a single context, which is unfortunate.