InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.71k stars 925 forks source link

Split declaration and implementation of GetSymbol #1969

Closed ljahn closed 8 months ago

ljahn commented 8 months ago

When I was adding the new SimpleWeatherService to my Star Trek Watchface, the linker got confused about multiple implementations of Pinetime::Applications::Screens::Symbols::GetSymbol. Including WeatherSymbols.h in two different files declared and implemented it two times.

This fixes that problem, by splitting the declaration and implementation of said function.

github-actions[bot] commented 8 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed