search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.71k stars 925 forks source link

Show blue icon when connected, grey when disconnected and hide when disabled #1974

Open riban-bw opened 8 months ago

riban-bw commented 8 months ago

This PR changes behaviour of bluetooth icon display.

Previous behaviour was that the icon showed coloured white when enabled and connected.

New behaviou is that the icon shows blue when connected, grey when disconnected and is hidden when disabled. This provides more info in the same space and is consistent with many common implementations which may offer a more familiar workflow.

github-actions[bot] commented 8 months ago
Build size and comparison to main: Section Size Difference
text 369816B -2812B
data 940B 0B
bss 63516B 0B
minacode commented 8 months ago

How is the contrast of the blue icon on the black background? Alternatively white for "connected" would also be an option.

riban-bw commented 8 months ago

Blue is okay but I did change it to white because it may be simpler and more stylish to have a monochromatic status. I will commit the change to this PR.

lassogames commented 1 month ago

I just started having some Bluetooth issues with mine and it would certainly help for some high level troubleshooting. I don't really know if my device is broadcasting bluetooth, if the radio is on, or if there is just a connection issue with my phone. Either way this seems like a nice feature.