search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.63k stars 902 forks source link

Rationalise use of status in faces. #1975

Closed riban-bw closed 5 months ago

riban-bw commented 5 months ago

This PR adds StatusIcons to WatchFaceAnalog. This rationalises the use of StatusIcons that was previously used on many screens but not the analogue watchface. The core advantage is that we have common code that reduces undesirable or unexpected behaviour, e.g. changes to StatusIcons would not be evident in the analouge watch face.

github-actions[bot] commented 5 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
FintasticMan commented 5 months ago

This has been discussed before: #1336 and #1963.

riban-bw commented 5 months ago

Okay - I will review those threads. I discovered the issue because the analogue face behaves different to other faces / apps which gives an inconsistent UI. Hopefully I will find some info in one of those threads that provides a roadmap for resolving this issue.