search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.63k stars 902 forks source link

Add option to keep display on always #1976

Closed riban-bw closed 5 months ago

riban-bw commented 5 months ago

The PR adds an option to keep the watch display always on. Previously there were options to keep the diplay on for:

This change offers options:

Display can still be turned off (sleep) with button press.

There may be apps or workflows that require the display to remain on until manually turned off or where the available durations are not sufficient.

github-actions[bot] commented 5 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
FintasticMan commented 5 months ago

There is already a pull request that adds an always on feature that allows for both always-on display and relatively good battery life: #1869. Apps can already set doNotSleep to prevent the watch from sleeping while the app is running. Because of this, I unfortunately don't think we will be merging this PR. Thank you for your work though!

riban-bw commented 5 months ago

Okay - thanks for the info about doNotSleep which I shall use in the app for which this will be desirable. I look forward to seeing https://github.com/InfiniTimeOrg/InfiniTime/pull/1869 integrated in a future release. (For now I shall use my patched fork.) Cheers!

riban-bw commented 5 months ago

I think the setting is called doNotGoToSleep and is only for system tasks, not screens. Is there a way for a screen / app to disable sleeping?

FintasticMan commented 5 months ago

Yes, an example is here: #681.