search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.63k stars 902 forks source link

settings: Add sleep/wake notification times #2002

Open chmeeedalf opened 4 months ago

chmeeedalf commented 4 months ago

Add configure screens for sleep and wake notification times, so the watch can automatically set notifications to sleep or on as applicable.

This could probably be done in a much better way, but I didn't want to refactor the whole date/time UI to add this. An alternative, doing that, is to create a widget base class for all time-like setting widgets, and derive from that for each of the various interfaces.

github-actions[bot] commented 4 months ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
JF002 commented 4 months ago

Hi and thanks for your first contribution to the InfiniTime project ! Could you explain into more detail what those changes do? Maybe add a few screenshots of the new UI?

Oh and also do not forget to check that those changes are consistent with the InfiniTime vision.

FintasticMan commented 4 months ago

I think this is similar to #1461, right? I think this is a very useful feature, let's decide on a good implementation together. It might be good if you could upload pictures from InfiniSim to see the UI.

chmeeedalf commented 4 months ago

@FintasticMan yes, it's exactly like that, I didn't see it before. Here are a couple screenshots:

image

image

image

(I noticed I forgot to change "current time" in my code, until I looked closer to get the screenshot).

Setting sleep and wake times to the same value disables the operation.