Notification popup does not show when an app is open, even if the screen is off

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS

GNU General Public License v3.0

2.76k stars 944 forks source link

Notification popup does not show when an app is open, even if the screen is off #204

Closed thanos-the-tank-engine closed 3 years ago

thanos-the-tank-engine commented 3 years ago

I understand not having the notification popup when an app is in use and believe that to be a useful feature, but it stops being a feature once the screen is off.

JF002 commented 3 years ago

What do you mean? The notification should be displayed even if an app was open and the screen went off (sleep mode)?

ncartron commented 3 years ago

Agreed with @willlovesbearz - just tested on 0.13.0 / Amazfish (SFOS):

open an app
force a notification to be sent by the phone => the PineTime vibrates, but no notification appears on the screen

same behavior when screen is off:

open an app
wait for the screen to go off
force a notification to be sent by the phone => the screen wakes up, PineTime vibrates, but only the previously loaded app is displayed, not the notification

petterhs commented 3 years ago

Yes it's currently just showing notifications when in the default Clock screen, even with screen off. We could add a acceptNotification boolean to each screen, so each app can "decide" if it wants notifications or not. Assuming we don't want notifications while playing a game for instance.

petterhs commented 3 years ago

This issue is not present anymore and could be closed @willlovesbearz