search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.63k stars 901 forks source link

Alarm status on infineat #2068

Open Eve1374 opened 3 weeks ago

Eve1374 commented 3 weeks ago

This branch modifies WatchFaceInfineat to have the possibility via the settings to show the alarm status. The settings screen of the watchface was modified accordingly. It handles 24hrs and 12hrs time format, though the screen is a bit crowded in 12hrs format. The idea came because I find it convenient to quickly verify that I set up the alarm for the next morning without going to the menu. Screenshots are displayed in doc/alarmStatusOnInfineat/alarmStatusOnInfineat.md

github-actions[bot] commented 3 weeks ago

Build checks have not completed. Possible reasons for this are:

  1. The checks need to be approved by a maintainer
  2. The branch has conflicts
  3. The firmware build has failed
bbadrignans commented 3 weeks ago

Thanks @Eve1374 for this helpful feature. In your first commit don't you add unnecessary files : the directory "node_modules " ? You may also rewrite your commit history to have only one clean commit : it is easier for maintainers to review. If you don't know how to to, for instance look at how to combine commits

jmlich commented 1 week ago

Btw I was trying to add alarm indicator into StatusIcons in this pull request https://github.com/InfiniTimeOrg/InfiniTime/pull/1884 I plan to rebase it to current master.