InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.75k stars 941 forks source link

Improvements to "Find my Watch" #393

Open Avamander opened 3 years ago

Avamander commented 3 years ago

The current "Find my Watch" functionality utilizes the call notification functionality. I think it wouldn't be a bad idea to separate this functionality into a separate watchapp alongside "Find my Phone" feature (https://github.com/JF002/InfiniTime/issues/343).

The current implementation has the downsides that:

Raupinger commented 3 years ago

The lather two shouldn't be an issue once #342 gets merged, but I agree that there should be proper UI for this

JF002 commented 3 years ago

I think gadgetbridge send a "real" phone call (to the point of view of InfiniTime) when the feature Find my Watch is activated, and that's why InfiniTime displays a call notification ;)

But yes, I agree that it's not the most relevant UI for the functionality. I can't remember if the Alert Notification Service / Find My Device profile define a specific notification type for this functionality but if it's the case, that would be trivial to implement it in InfiniTime and companion apps.

ObiKeahloa commented 3 years ago

I think gadgetbridge send a "real" phone call (to the point of view of InfiniTime) when the feature Find my Watch is activated, and that's why InfiniTime displays a call notification ;)

But yes, I agree that it's not the most relevant UI for the functionality. I can't remember if the Alert Notification Service / Find My Device profile define a specific notification type for this functionality but if it's the case, that would be trivial to implement it in InfiniTime and companion apps.

This is true , the mi band 5 (Supports gadgetbridge) gets a call from the gadgetbridge app this is probably true for the PineTime too!

Thus GadgetBridge has to change it or we have to do some blackmagic.