search

InfiniTimeOrg / InfiniTime

Firmware for Pinetime smartwatch written in C++ and based on FreeRTOS
GNU General Public License v3.0
2.71k stars 926 forks source link

When on a call, rejecting an incoming call ends the current call #952

Closed pbryan closed 2 years ago

pbryan commented 2 years ago

Verification

What happened?

While on a call, received an incoming call, and notification; rejecting the call on InfiniTime ended the current call.

What should happen instead?

Rejecting the incoming call in InfiniTime should reject the incoming call.

Reproduction steps

  1. Install Gadgetbridge on Android phone.
  2. Receive a call on Android phone.
  3. While on call, receive another incoming call.
  4. Reject the second incoming call in InfiniTime.
  5. Observe that the current call has been terminated.

More details?

Hardware: PineTime.

Version

1.8.0

Companion app

GadgetBridge 0.64.0

JF002 commented 2 years ago

I think this is an issue for Gadgetbridge. InfiniTime does not know if the call notification corresponds to a "first call", or to a second call coming on top of the 1st one, it just receives a call notification from Gadgetbridge and notifies Gadgetbridge when the "reject" button is tapped.

pbryan commented 2 years ago

OK, thanks, I'll raise it in Gadgetbridge.

JF002 commented 2 years ago

It would be nice to know if this feature is supported by other devices and how it's implemented. Maybe we'll need to extend the current API to support multiple calls.

pbryan commented 2 years ago

Here is the Gadgetbridge issue.

pbryan commented 2 years ago

Will update this issue as I learn more.