search

Infinidat / ansible-infinidat-collection

A set of Ansible modules that allow simple, but powerful, idempotent interactions with Infinidat InfiniBoxes.
Other
1 stars 1 forks source link

License questions #1

Closed gundalow closed 3 years ago

gundalow commented 4 years ago

Hi, It's great to see you've created a collection for the Infinidat content, thank you.

The original modules from Ansible were GPLv3+ and the module_utils were GPLv3+/BSD.

I can see that you've set the Apache license in the root of the repo, and also in every file, ie https://github.com/Infinidat/ansible-infinidat-collection/blob/develop/plugins/modules/infini_export.py#L4

If we look at the original for the above file https://github.com/ansible/ansible/blob/pre-ansible-base/lib/ansible/modules/storage/infinidat/infini_export.py we can see that 7 people have contributed to this.

You can't relicense without getting sign off from all contributors to all files, please speak to your legal team for further advice.

anshulbehl commented 4 years ago

@sqqqrly Can you check and comment on this?

gundalow commented 4 years ago

@sqqqrly @ekaulberg thank you in advance for looking into this.

Friday 10th July is the deadline to get content moved out of community.general if you want it to be included in the Ansible 2.10 release.

ekaulberg commented 4 years ago

Hi @gundalow and @anshulbehl. Thanks for looping me in. As @sqqqrly is OOO/offline for the next week and a half, I'll try to get this addressed in his absence, but realistically may not be able to close all the open switches before Friday.

sqqqrly commented 4 years ago

Hi @gundalow and @anshulbehl. I just saw this. This will be fixed this morning.

gundalow commented 4 years ago

@sqqqrly That's great, thank you.

I believe the following needs addressing so this collection can be included in ansible 2.10:

thedoubl3j commented 4 years ago

@gundalow it is on galaxy, found here: https://galaxy.ansible.com/infinidat/infinibox

sqqqrly commented 4 years ago

The license has been reverted back to GPL. The collection was re-built and pushed as version 1.2.3 at https://galaxy.ansible.com/infinidat/infinibox. The change was tagged as v1.2.3.

felixfontein commented 4 years ago

I just checked some of the files. It looks like you removed the original copyright statement by the orignal author:

# Copyright: (c) 2016, Gregory Shulov <gregory.shulov@gmail.com>

and replaced it with

# Copyright: (c) 2020, Infinidat <info@infinidat.com>

I'm not sure this is legal.

ekaulberg commented 4 years ago

Hi @felixfontein and @gundalow - original author Gregory Shulov was an Infinidat employee doing this as part of his work activities. He was subject to a standard assignment clause in his employment agreement, so the copyright really rests with Infinidat already. The copyright line should have been written for Infinidat originally but we didn't have much of a process to ensure that at the time of authorship.

sqqqrly commented 3 years ago

Licensing addressed.