search

Infinidat / infi.pyvmomi_wrapper

BSD 3-Clause "New" or "Revised" License
14 stars 11 forks source link

Update `DictMixIn` import. #13

Closed jerverme closed 2 years ago

jerverme commented 3 years ago

Here's a change I'd like to suggest. The code in resources.py imports DictMixIn in one of two ways: the python 2.x way, and if that fails, the python 3.x way.

Unfortunately that python 3.x way has now been replaced with a new python 3.x way, and the next major python release will drop the compatibility shim.

So, this change tries all three ways of importing DictMixIn. And also, because I figured it'd make sense, it tries the most modern import first. Only when that fails does it fall back on the older way, and if that fails, it goes all the way back to the 2.x way.

(Of course this assumes that the old import is still useful. If not, things could be a lot simpler.)

jerverme commented 2 years ago

Meanwhile, python 3.10 has been released and it did remove that symbol. So this fix is now pretty urgent!

jerverme commented 2 years ago

Thanks! I don't think I have the rights to merge it myself (which makes sense, since I'm not on the project), so could you do that?