fix firewall inconsistencies

Infinidoge / nix-minecraft

An attempt to better support Minecraft-related content for the Nix ecosystem

MIT License

174 stars 18 forks source link

fix firewall inconsistencies #25

Closed Misterio77 closed 1 year ago

Misterio77 commented 1 year ago

There were a few errors with the openFirewall implementation:

Server port was UDP instead of TCP
Query port was TCP instead of UDP
UDP ports were opened on TCP needlessly (this hid the above errors)

Infinidoge commented 1 year ago

Huh, Query is UDP and not TCP? This needs to be fixed in base Nixpkgs then, since I pretty much lifted that entire setup straight from Nixpkgs, modifying it to account for multiple servers. (For reference)

Misterio77 commented 1 year ago

Huh, Query is UDP and not TCP?

Yup!

This needs to be fixed in base Nixpkgs then, since I pretty much lifted that entire setup straight from Nixpkgs, modifying it to account for multiple servers. (For reference)

Hmmm we should fix that

Infinidoge commented 1 year ago

Sorry for taking so long, thanks for the contribution!