search

Infinidoge / nix-minecraft

An attempt to better support Minecraft-related content for the Nix ecosystem
MIT License
172 stars 18 forks source link

feat: remove deprecated outputs.packages attribute #33

Closed soupglasses closed 1 year ago

soupglasses commented 1 year ago

Due to the nature of how the packages are exposed in nix-minecraft currently, they do not fit the pattern as required by flakes. This PR removes the packages attribute so to fully rely on legacyPackages instead.

This is done due to all nix tooling that supports flakes complain about the attributes of nix-minecraft (nil_ls, nix flake, etc).

This also closes #11 simply because this repository has grown too much to be able to upkeep such a huge PR. It will likely get repurposed into a hard fork with a smaller scale, current plan being making it fabric only.

soupglasses commented 1 year ago

An example screenshot from nil_ls complaining about the broken derivations this repo ships.

Screenshot from 2023-05-12 09-57-43

Infinidoge commented 1 year ago

Worth noting, the packages attribute as a whole isn't deprecated. Rather, the attrsets within it are. (Note the block that maps the warning.)

Also, funnily enough, I actually already have a commit ready for this: https://github.com/Infinidoge/nix-minecraft/commit/1dcc182a45bf641bbf175d7a169049f1b66269f0.