Infinidoge / nix-minecraft

An attempt to better support Minecraft-related content for the Nix ecosystem
MIT License
172 stars 18 forks source link

tests: init #38

Closed Misterio77 closed 8 months ago

Misterio77 commented 1 year ago

Hi! This is me again, with the first of 4 PRs this time xD

This PR adds simple NixOS integration tests, which can be run with nix flake check (or individually with nix build .#checks.x86_64-linux.simple).

For now, there's two:

Infinidoge commented 1 year ago

Looks pretty good to me. Will do local testing to make sure everything is good before merging.

Misterio77 commented 1 year ago

For normal usage, we usually can assume the user will have internet connection, but I fully agree, we should totally add that to passthrough and document it; I'll do this in a minute.

Misterio77 commented 1 year ago

There you go: https://github.com/Infinidoge/nix-minecraft/pull/44

Infinidoge commented 8 months ago

Sorry for taking so long to merge this. While I do have the excuse that I've been busy with college, it really shouldn't have taken so long to merge a PR of this size. Thanks again for the contributions!