Currently shipping broken fabric server derivations

Infinidoge / nix-minecraft

An attempt to better support Minecraft-related content for the Nix ecosystem

MIT License

174 stars 18 forks source link

Currently shipping broken fabric server derivations #9

Open soupglasses opened 1 year ago

soupglasses commented 1 year ago

Current broken fabric servers that i have found are all due to missing vanilla variants.

All combat versions.
All experimental-snapshot versions.
All deep-dark-expermimental-snapshot versions.

I would say we should look into seeing if whitelisting known minecraft versions for fabric in the update.py file. For example, i can currently find the pre, rc, oneblockatatime, Pre-Release, infinite in vanillaServers from a quick look over.

soupglasses commented 1 year ago

Luckily quilt-servers packages only recent enough minecraft versions that this is not an issue there currently.

soupglasses commented 1 year ago

Also the current fabric-servers/libraries.json ships with multiple empty hashes, causing errors if you try to build these versions.

List:

1.14.2 Pre-Releases
1.14.1 Pre-Releases
1.14 Pre-Releases
3D Shareware v1.34

This is a small enough amount that this may be able to be manually updated.

Infinidoge commented 1 year ago

Hmm, I think the better solution for the missing vanilla variants in particular would be to include them, since they should be packaged.

For the empty hashes, yeah they can be done manually (or I suppose completely regenerate libraries/locks). Might look into making the update script check for empty hashes and regenerate if necessary.

soupglasses commented 1 year ago

These are now all building correctly under #11 and will be fixed upstream when the PR gets finalized.