Fix incorrect state when RCing fast (#13)

[Infinitay]

• Track when user is crafting runes to manually handle pouch and inventory state

  • Listening for StatChanged and FakeXpDrop to determine if a player crafted runes
  • Primarily for emptying pouches as that's where the issue was occuring where stored essence was incorrect
  • Tracks when a user runecrafts and added properties to track the last craft action and it's tick

• Revert change that added all tasks to the PouchActionTask queue

  • Only add to the queue if the pouch task was successful

• Added logic to handle rune crafting by checking menu actions and confirming successful crafting via XP drops.

• Changed to use injected developerMode instead of self-defined variable

• Only render debug overlay when on dev mode

• Moved #updatePreviousInventoryDetails call before modifying current inventory properties for proper sequence

• Adjusted tracking state to update when pouches are checked

• Added a debugging overlay panel when in dev mode to help with debugging inventory state

  • Primarily useful for recording footage and slowing it down since the interactions that cause incorrect state happen faster than game ticks so <600ms and it's hard to notice without recording and slowing down.

• Add createdAtGameTick to PouchActionTask to track when pouch action tasks were created

• Add a pouch action task to the task queue when in the middle of runecrafting as well

• Clear the current task queue when interacting to craft runes as those actions are invalid now

• Clear the task queue if the task expired as those actions are invalid now

• Refactor FakeXpDrop and StatChanged events task queue initialization (removed filters) and processing

  • Add all current PouchActionTasks to the temporary queue (empty/fill)
  • Process actions by using PouchActionCreated events

• Fix issue where crafting combination runes weren't being handled

  • Added craft-rune menu option handling

Fixes #13

[Infinitay]

I iteratively tested the changes for 10 minutes at Astral's and didn't have an issue. I then went to test it longer while doing GOTR for around 30-40 minutes. Again, I couldn't actively recreate the issue where emptying the pouch returned an incorrect state like before when runecrafting and trying to empty the pouches too quickly. However, it did happen to me just once where one pouch state was incorrect. I'm not exactly sure why because I didn't save the logs or footage of it happening to slow it down and see the plugin state slow enough to see actions/values faster than ticks.

I'll keep testing this PR for another hour or so to see what happens. However, even in the current state, I am confident that it is more accurate and useful than the existing Runecrafting plugins that are related to pouch tracking. That's why I'm still expecting to push these changes even if the issue persists albeit not often. It would be good to also implement #14 soon too.

I also am planning on adding a feature that will highlight pouches to empty according to inventory free space. I've already handled checking to see if the player is crafting runes so it should be relatively easy to do so too. A benefit of adding this feature would be that it would hopefully mitigate attempting to RC too quickly and causing wrong states.

[Infinitay]

TODO Refactor the code since there's lots of reused code I'm noticing after this PR primarily for removing (emptying) essence but also a few for adding essence. Currently, I'm planning to refactor it on another PR so I'll probably leave the PR as is.

[Infinitay]

Rebased branch onto main which brought in the degraded pouch fix from #18

[Infinitay]

Again, I couldn't actively recreate the issue where emptying the pouch returned an incorrect state like before when runecrafting and trying to empty the pouches too quickly.

However, even in the current state, I am confident that it is more accurate and useful than the existing Runecrafting plugins that are related to pouch tracking.

Noticed that this tends to happen in GOTR more often than regular runecrafting because in GOTR you get extra items when crafting that are only available for the minigame. I believe the issue is my inventory update blocking logic. Potential solutions:

1. Refactor inventory updating
2. Keep it simple and allow inventory updates if GOTR items were added to the inventory
   • Perhaps it's time to consider a utility class for all is<>ValidItem methods that check items

[Infinitay]

After the latest commit, I tested the plugin at GOTR for over 30 minutes and didn't face any immediate issues. Even when dealing with odd inventory states such as not having enough space to empty to the pouch it would correctly have n remaining essence as it should. I want to test it more tomorrow at GOTR playing normally, and then I want to test it by trying to break it both at GOTR and regular RCing such as at Astrals.

[Infinitay]

50 minutes of GOTR and 10 minutes of astrals - I couldn't break the plugin. I'm going to try for a bit longer and accept the PR. Over 2 hours of GOTR and 30-45 minutes of Astrals