Closed Infinitay closed 8 hours ago
Avoiding merging this until I test it with a few actual runecrafting runs. I tested this at a bank briefly and it seemed to function as intended but I'm lacking sleep right now, and I don't want to push a broken fix.
Changes for e11b730 and 981f7b0
storedEssence
and remainingEssenceBeforeDecay
pauseUntilTick
to -1
when a PouchAction event returns false in order to allow inventory updates onItemContainerChangedunknownStored
Reset the plugin and started a game of GOTR everything was working fine until a pouch degraded. Missed checking for degraded pouches for #36. Other than that, everything was okay.
I started the game resetting the plugin.
The only issue was when a pouch degraded and that is due to pouches
map changes from the previous PR. Test this PR again after fixing the degraded pouches map.
I realized that when checking a pouch with an unknownStored
flag, it would reset the state back. This was because it was loading the save state, but it was never updated after setting the pouches after the check. Fixed with a0a129e
TODO
Also, I am debating whether or not to change it such that we only load the tracking state once on GameState.LOGGED_IN
. This is because there are different times that state fires:
It might be best to just load the tracking state when the player first logs into the game. Perhaps something to consider in the future if I ever refactor.
EssencePouch
unknownStored
in #empty return 0unknownStored
in #fill return 0remainingEssenceBeforeDecay
state if the pouch also hasunknownDecay
in #fillEssencePouchTrackingPlugin