search

InfiniteAmmoInc / Yarn

932 stars 92 forks source link

Panning using Alt+Drag produces heavy lag immediately #62

Closed tlein closed 6 years ago

tlein commented 6 years ago

Problem: When using Alt+Drag to pan the canvas it will work smoothly for ~1 second and then suffer from heavy slowdown. Provided is a screenshot with an example. yarn_lag This problem occurs in both master (commit c353da7604b3cb9e3bd14897a3dc64601eebf9e5 at the time of writing this issue), and in the released 2016-08-15 build. I have only confirmed it in Windows.

I opened the devtools and profiled the action, nothing immediately jumps out, there's some garbage collection spikes but only 2 of them within a 5 second timeframe. Everything else seemed consistent across the entire profiling session.

benswinden commented 6 years ago

Found the commit that broke it.. it's been busted for a long time haha.. wondering why nobody else brought this up? Here's the offending commit: https://github.com/InfiniteAmmoInc/Yarn/commit/cd6f73a628f8f9c6ec12dd9b59aac7b5773cd3f8

AndrewD2 commented 6 years ago

Probably easiest for you to fork and submit and PR.

addie-lombardo commented 6 years ago

Added to master in https://github.com/InfiniteAmmoInc/Yarn/commit/7e2238547f2841a20fa1b1d4329ca4672b1eb644, closing.