InfiniteAmmoInc / Yarn

934 stars 93 forks source link

Brackets cause issues with inputted text #69

Closed SkyAphid closed 6 years ago

SkyAphid commented 6 years ago

Sorry for the weird title. To avoid confusion, I've attached a screenshot to hopefully explain the problem better.

My game uses a tag system of its own for identifying characters and objects, such as [[PLAYER_NAME]]. Coincidentally, you guys use the same scheme for indicating branching dialogue. This has caused a small issue, as you can see in the screenshot.

A simple solution is to just have it identify the last set of brackets for indicating branching dialogue, rather than having it select the first.

Thank you for your time! And the software works, looks, and feels great!

yarn bug

blurymind commented 6 years ago

I think your syntax is incorrect. The brackets are used for branching dialogue choices, not for calling variables like that. Your card is not even branching

I would assume that it should be $PLAYER_NAME @jhayley can you advise? :)

Are you using yarnspinner for this (Unity3d)? If so, your issue should be for the yarnspinner issue tracker- not this one

SkyAphid commented 6 years ago

We use a custom game engine, it's not part of any existing toolset. We were going to add support for Yarn to it, but ran into this bug. Best case scenario you'd just need to tweak the code to switch the ending bracket identifier to use the last set rather than the first.

blurymind commented 6 years ago

@SkyAphid is the problem you describe a cosmetic issue with the editor? The letter coloring? Or is it something that occurs ingame?

You know that you are free to edit the code to change the behavior to fit your syntax :)

SkyAphid commented 6 years ago

It's definitely cosmetic and appears to work fine on export, but it's still hard to work with. I tried editing your code but had a bit of trouble wiring everything up the way I wanted, so I ultimately ended up writing my own dialogue editor. Thanks anyway for your time! I really appreciate it.

addie-lombardo commented 6 years ago

Issue has been dropped, closing.