search

InfiniteAmmoInc / Yarn

934 stars 93 forks source link

Fixes for Electron port on MacOS #72

Closed julsam closed 6 years ago

julsam commented 6 years ago

The first 2 commits are MacOS specific bugfixes:

  1. cbb2a21 fixes a bug preventing the app from running completely. Here's a screenshot of the default menubar button: screen shot 2018-07-08 at 01 04 23 I don't know if we should build a more complete menubar or not.
  2. dccf0b0 resizes the yarn icon so electron-builder can build the app for releases

The last 4 are less MacOS specific, but are still cleanups.

I could also provide a MacOS build if anyone interested.

I still have a lot of fixes / improvements to commit, not sure if i should make a different pull request for each, or add them here? Whatever's the most convenient for you @charblar

addie-lombardo commented 6 years ago

Hey, thanks for the fixes!

Building out the menu bar is a good idea, create an issue for it! I can do a MacOS build I just have been busy the past couple weeks but will hopefully have one up soon.

Additional pull requests per feature are appreciated but if your doing general bug fixes and smaller changes you can do a single PR as long as you keep your commit descriptions informative (as you have).