search

InfiniteAmmoInc / Yarn

932 stars 92 forks source link

No connections are drawn when opening a Yarn file #78

Closed swakdaddy closed 5 years ago

swakdaddy commented 6 years ago

image

OS: Windows 10.

Repro steps:

Including a file I know isn't working.

Thanks!

Sally.yarn.txt

julsam commented 6 years ago

Thank you for your reporting this bug :+1:

It seems like the issue comes from the line ending. When using the yarn.txt save format, Yarn is expecting only Unix type line ending and doesn't interpret correctly CR that Windows add. By default Yarn saves using LF only, but I guess the text editor you used changed it to CRLF.

Should be easy to fix, but in the meantime you can convert your files from the Windows format to the Unix one and the connections should be back :wink: Here's your file converted: Sally.yarn.txt

Another quickfix would be to save it as a json file.

swakdaddy commented 6 years ago

Thanks for the great info and the source of the problem. I'm not sure what editor added CR. I only used Notepad++ and Visual Studio 2017. I just tested editing/saving with whitespace visible and neither added CR. I'll be sure to keep an eye out in the future.

Thank you! :-)

blurymind commented 5 years ago

ok I fixed this bug in my pull here: https://github.com/InfiniteAmmoInc/Yarn/pull/80 https://github.com/InfiniteAmmoInc/Yarn/pull/80/commits/1cc7e50e0717dfd1cefe474eef448c8e5601e096

blurymind commented 5 years ago

this is actually fixed in #79 , so I reverted my fix in #80

desplesda commented 5 years ago

Fixed in c50b77c.

swakdaddy commented 5 years ago

So I noticed that this fix doesn't seem to be included in Yarn-master somehow when you download the ZIP from Git. I opened up data.js and added the fix manually, but it doesn't seem to work. Dumb question, but do I need to compile something to get it to work?

blurymind commented 5 years ago

Please attach the example file :)

On Fri, Apr 12, 2019, 2:29 AM swakdaddy notifications@github.com wrote:

So I noticed that this fix doesn't seem to be included in Yarn-master somehow when you download the ZIP from Git. I opened up data.js and added the fix manually, but it doesn't seem to work. Dumb question, but do I need to compile something to get it to work?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/issues/78#issuecomment-482400903, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVTlQ_SndNiVaaXSIxbN1RV65IIRVks5vf-GIgaJpZM4WLhMz .

swakdaddy commented 5 years ago

The example file is already attached in the original post. See Sally.yarn.txt above. It has the Windows-style line endings. But, the problem is that this fix isn't in the git repo it seems. At least, not when I download it like this:

image

If you are talking about data.js, I simply changed the line in this change list to match what is supposed to be in git. It does not work locally by changing that file and then running Yarn by dragging Yarn-master folder into nw.exe. It's the only way I've found to run latest version of Yarn.

blurymind commented 5 years ago

@swakdaddy this was fixed on the electron branch. You need to use that instead of master https://github.com/blurymind/Yarn/releases/tag/0.3.6

swakdaddy commented 5 years ago

@blurymind - Ah thanks. I'll grab the electron branch then since it seems you guys have been working more on it!

blurymind commented 5 years ago

It has alot of the issues here fixed, it's just not the default branch yet for some reason

On Thu, Apr 18, 2019, 4:51 PM swakdaddy notifications@github.com wrote:

@blurymind https://github.com/blurymind - Ah thanks. I'll grab the electron branch then since it seems you guys have been working more on it!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/issues/78#issuecomment-484569794, or mute the thread https://github.com/notifications/unsubscribe-auth/ABRRWVKOOO5GNZ26772A7Q3PRCKG7ANCNFSM4FROCMZQ .