search

InfiniteAmmoInc / Yarn

934 stars 93 forks source link

Fix for issue #78 loading yarn.txt with \r\n lines #79

Closed julsam closed 5 years ago

julsam commented 5 years ago

When loading a yarn.txt file, Yarn was expecting lines to end only with \n and didn't handle properly lines ending with \r\n.

Yarn saves files using only \n, even on Windows, but if the user modify the file manually, some editors on Windows will convert \n to \r\n, so it must be taken into account.

blurymind commented 5 years ago

ah sorry, I didnt realize you have already fixed it. I will revert the fix in my pull #80

julsam commented 5 years ago

All good @blurymind :ok_hand: I hope one of the maintainers will come here and check our pull requests, it's been pretty dead since this summer :disappointed:

blurymind commented 5 years ago

it would be nice if this project had more than one maintainers. From my understanding it's only @charblar atm and he's probably having trouble dedicating time

blurymind commented 5 years ago

btw I fixed the issues noted in #83

desplesda commented 5 years ago

Merged into electron.