search

InfiniteAmmoInc / Yarn

934 stars 93 forks source link

Version 0.2.1 Yarn Files Break in Version 0.3.5 of Yarn Portable #91

Closed tomdominer closed 5 years ago

tomdominer commented 5 years ago

I've created a simple story introduction file in yarn which doesn't get properly parsed in Yarn 0.3.5.

Nodes appear to be missing (i.e. Story.Apartment.Forms doesn't appear) and connections are lost. Also, if you open any node with connections (i.e. Choice.Green.Circle) it seems to break the 0.3.5 editor as you cannot close the node afterwards.

File Open in 0.2.1 yarn_file_open_in_0_2_1

File Open in 0.3.5 yarn_file_open_in_0_3_5

Yarn File Causing The Problems Act1.Story.yarn.txt

tomdominer commented 5 years ago

Delving a bit deeper, it seems to be related to the newer version of yarn not being able to handle node connections without a label. Using the YarnSpinner documentation as an example, if you just put in [[GoToCity]] into a story node, without that node existing, the editor tries to create a node connection seems to fail, making about five new nodes and stops you from closing the node editor window.

blurymind commented 5 years ago

Thank you for attaching an example. Some of the new features have introduced a few regressions. I have fixed some of them on git, but haven't released a build yet

On Mon, Feb 4, 2019, 12:52 PM tomdominer <notifications@github.com wrote:

Delving a bit deeper, it seems to be related to the newer version of yarn not being able to handle node connections without a label. Using the YarnSpinner documentation as an example, if you just put in [[GoToCity]] into a story node, without that node existing, the editor tries to create a node connection seems to fail, making about five new nodes and stops you from closing the node editor window.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/issues/91#issuecomment-460238547, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVe6QgnoZz1ttgkxGrZGP9gpZ1JHmks5vKCz4gaJpZM4ahFZq .

blurymind commented 5 years ago

Hi, I can confirm that this has been fixed in the latest git version already via https://github.com/InfiniteAmmoInc/Yarn/commit/88e44eccb07434b10503d1499f57da2db1850de2 . I will soon release a new build. If you build electron version from git, it works

blurymind commented 5 years ago

build with a fix: https://github.com/blurymind/Yarn/releases/tag/0.3.6

tomdominer commented 5 years ago

Check and fixed in version 0.3.6.