InfiniteAmmoInc / Yarn

934 stars 93 forks source link

Yarn 0.3.5 Cannot Handle Node Connections Without a Label #92

Closed tomdominer closed 5 years ago

tomdominer commented 5 years ago

Using the Yarn Spinner [example dialogue documentation](https://github.com/thesecretlab/YarnSpinner/blob/master/Documentation/YarnSpinner-Dialogue/General-Usage.md) as an example, if you create a new node and then paste in [[GoToCity]] as a node link without a lable, the editor seems to bug out. You cannot close the node, the text appears incorrectly and when you delete the text and then close the node the yarn editor has created 7 new node connections.

blurymind commented 5 years ago

Thank you for reporting. I will look into it

On Mon, Feb 4, 2019, 1:01 PM tomdominer <notifications@github.com wrote:

Using the Yarn Spinner example dialogue documentation as an example, if you create a new node and then paste in [[GoToCity]] as a node link without a lable, the editor seems to bug out. You cannot close the node, the text appears incorrectly and when you delete the text and then close the node the yarn editor has created 7 new node connections.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/InfiniteAmmoInc/Yarn/issues/92, or mute the thread https://github.com/notifications/unsubscribe-auth/AGMbVf26FqwJ-jRkg9wP8MIrtWwGfGXFks5vKC8ygaJpZM4ahJrc .

blurymind commented 5 years ago

can you provide an example file again please. It is really helpful with fixing these regressions

blurymind commented 5 years ago

I think this is the same as https://github.com/InfiniteAmmoInc/Yarn/issues/91, if so it has already been fixed. I just need to release a bugfix build soon. Can you confirm please?

tomdominer commented 5 years ago

Yeah, I think they are the same issue. Hard to tell without debugging myself. I can close both once you release a new build, though. :)

tomdominer commented 5 years ago

Where should I be looking for a new build @blurymind ? On the main fork page

blurymind commented 5 years ago

I havent uploaded it yet. Will do tonight.. same place where you got 0.35

blurymind commented 5 years ago

build with a fix: https://github.com/blurymind/Yarn/releases/tag/0.3.6

tomdominer commented 5 years ago

Check and fixed in version 0.3.6.