Infinity-Evolved-Reloaded-Modpacks / Infinity-Evolved-Reloaded

Infinity Evolved Reloaded Modpack for Minecraft 1.12.2
GNU Lesser General Public License v2.1
8 stars 15 forks source link

Agricraft quests no completing #273

Open Theta1996 opened 8 months ago

Theta1996 commented 8 months ago

General Info (please complete the following information):

Describe the bug Working through crop breeding to get necessary seeds for a watering can, I noticed that although I have completed the prerequisites and have obtained the seeds ( say for example carrots and wheat crossed to make sugarcane seeds), the quest hasn't been marked as complete. Having manually marked the quest as complete I have noticed that it is hit and miss as to whether other plant quests auto-complete or not while cross-breeding

To Reproduce Steps to reproduce the behavior: E.g.:

  1. Obtain wheat and carrot seeds and plant on Agricraft crop sticks
  2. Crossbreed to produce sugar cane.
  3. Quest doesn't automatically mark as complete.

Screenshots [If applicable, add screenshots to help explain your problem.]

Crash-log [If applicable, add a crash-log. Usually a "crash-[date]-[time]-server/client.txt"]

saovenn commented 8 months ago

Hey, thanks for the report. Unfortunately, we are encountering issues with FTBQuests and AgriCraft (Seed's) NBT tags, which are preventing automatic completion / detection.

you could try to convert them to agricraft ( 1/1/1 ) and look if those are being detected

Theta1996 commented 8 months ago

All the seeds are 1/1/1 but still not being detected. I just did a quick test and setting the task item to ignore nbt data in the quest book seems to fix the issue. Edit: disregard that... Just did a little bit more seating and all Agricraft quests for Botania and vanilla flowers are have marked as completed just by obtaining one. I'll do some more tests and see if I can come up with something to fix the issue myside and update with anything that I find.

saovenn commented 8 months ago

seems so that the sugarcane quest is working for me 🤔

also the problem is, every agricraft seed has the same ItemStack ( which follows with an exact NBT for all of the three growth stages which are completely needed at the same

.withTag({agri_analyzed: 0 as byte, agri_strength: 1 as byte, agri_gain: 1 as byte, agri_seed: "vanilla:sugarcane_plant", agri_growth: 1 as byte})

so if you breed it and it has agri_strength at 2 it will not be detected.

if you change the NBT Tag from match to ignore it will only take which all AgriCraft seeds begin with.

you could try contain but thats also vague what it exactly means ^^

Theta1996 commented 8 months ago

Yeah, I found that out the hard way. Since there aren't any rewards tied with the quests, it's not a big deal. I'll keep playing with it and see if I can come up with anything. Though I looking at it at the moment, it looks like the only real way of getting it to work is by manually submitting the quest which I'm not totally against, but would be nice to have it working automatically

Theta1996 commented 8 months ago

After some playing around in creative, it looks like the quests work as they're meant to (within the limitations of crop stats). Turns out I'm just stupid as I didn't realise some of the seeds I was using were from Pam's gardens.

saovenn commented 8 months ago

might be changing it to the end product of those seeds and not the seed itself 🤔

Theta1996 commented 8 months ago

That could work as we wouldn't have to worry about the stats of the seed messing things up. Waiting for the seeds to grow also wouldn't be long, maybe add something about Agricraft's irrigation system to boost growth times without having to go and farm a bunch of bone meal?