search

InfinityLoop1308 / PipePipe

A FLOSS Android app to let you browse YouTube, NicoNico and BiliBili freely.
GNU General Public License v3.0
2.14k stars 46 forks source link

[bug] YouTube audio tracks #143

Closed evoke322 closed 11 months ago

evoke322 commented 1 year ago

When using YouTube, if the video has several audio tracks, even though I set the default content language to English, it doesn't play in English. maybe it is a bug.

What's more, could you consider add a function to switch audios?

sereksim commented 1 year ago

I've got the same problem. For example, videos from Marques Brownlee (MKBHD) are always in spanish, regardless of the language settings in the app. It is not possible for me to view these videos in the original language (english)

InfinityLoop1308 commented 12 months ago

It is almost impossible to reuse the code from NewPipe so a long time should be expected for the feature to be implemented. Please be patient.

Kr0n1Ku5 commented 11 months ago

@InfinityLoop1308 Hello, I was just wondering, if you don't mind answering. What exactly makes NewPipe code hard to reuse for PipePipe, since this is a fork? Unless its specifically for this feature and I'm misinterpreting.

InfinityLoop1308 commented 11 months ago

Good question. PipePipe is not really a fork like NewPipe x Sponsorblock. It is a hard fork, meaning it evolves independently and doesn't track NewPipe's updates. Since the fork two years ago, PipePipe and NewPipe have each developed hundreds of commits in completely different directions. This certainly makes merging their commits into an almost impossible task.

InfinityLoop1308 commented 11 months ago

Next version will include a patch to ensure the original audio is always selected.

InfinityLoop1308 commented 11 months ago

Should be fixed in 3.1.10