search

InfinityLoop1308 / PipePipe

A FLOSS Android app to let you browse YouTube, NicoNico and BiliBili freely.
GNU General Public License v3.0
2.1k stars 44 forks source link

[Feature request] Add an option for gain (volume goes above 100%) #382

Open xeroxslayer opened 2 months ago

xeroxslayer commented 2 months ago

Checklist (Your issue will be automatically closed if you delete this part)

I don't know why, but PipePipe as well as NewPipe (I presume the former is a fork of the latter) both have lower volume when everything is at max, when compared to the default YT app and the mods as well (ReVanced, ReVanced Extended, etc.). I presume this has maybe something to do with not honoring metadata gain that a video might have embedded.

Regardless, an option like this will be beneficial for hearing impaired people as well. I know this might damage the built in speakers or may cause ear damage, but a one time warning could be triggered if the value is raised above 100%.

I would have raised the same issue on NewPipe's repo, but there was a warning that said they're in the middle of a major rewrite and only accept bugfixes. So, I'm addressing this here, since I have no idea if PipePipe will follow the path NewPipe will be taking.

In conclusion, even if the real issue behind the volume/gain difference is found (the volume difference is definitely 3dB or more, I would be inclined to say more like 6dB), I believe an option like this would be something that would benefit everyone.

bjspi commented 2 months ago

Second this, especiallly when driving in the car without being connected to the car speakers.