InfinityStudio / GokiStats

GokiStats, a Minecraft mod, RPG
GNU General Public License v3.0
25 stars 12 forks source link

Bugs that need to be fixed #43

Open Climeron opened 4 years ago

Climeron commented 4 years ago

Tested on version 1.2.7.2 This mod is very cool and I would like to play with it without the following bugs.

LasmGratel commented 4 years ago

"At death, there is a chance that skills will be reset" I cannot reproduce this in my clean environment, many reports but Forge's SimpleImpl works just as fine as other mod Check if any mod cancelled PlayerDeathEvent or something takes control of health system If this still happens, I will consider synchronizing all stats in a regular time

I believe Athleticism shall be working correctly in 1.13

Other bugs will be fixed.

rtxyd commented 4 years ago

@NanamiArihara Actually, I got "death reset" problem too. Many people in Chinese forum also feedback this problem. But what I encountered was not really reset, it just displayed as 0, the real level did not change. Though I need downgrade it to made it right.

LasmGratel commented 4 years ago

I cannot reproduce this bug. Breakpoints at respawn event are fired as usual. Can you provide your personal NBT data?

From: rtxydmailto:notifications@github.com Sent: Saturday, May 16, 2020 8:40 PM To: InfinityStudio/GokiStatsmailto:GokiStats@noreply.github.com Cc: Nanami Ariharamailto:lasm_gratel@hotmail.com; Mentionmailto:mention@noreply.github.com Subject: Re: [InfinityStudio/GokiStats] Bugs that need to be fixed (#43)

@NanamiAriharahttps://github.com/NanamiArihara Actually, I got "death reset" problem too. Many people in Chinese forum also feedback this problem. But what I met was not really reset, it just displayed as 0, the real level did not change. Though I need downgrade it to made it right.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/InfinityStudio/GokiStats/issues/43#issuecomment-629639641, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABS4INNNA3XZME2ZPWVOXA3RR2CUDANCNFSM4KWHVKWQ.

rtxyd commented 4 years ago

where can I get my personal NBT data? @NanamiArihara and what time of the NBT do you want?

rtxyd commented 4 years ago

I found a complement of this issue, if the skill is not at highest level, and I died, I need cost xp(the amount is level 0 to level 1) to left click the skill to make it show the right level. Previous message just showed what it performs at highest level. (not like issue#43 says, every time I die it comes. Re-enter the world could not solve it)