InfinityStudio / HMCL

A powered Minecraft launcher that supports a lot of features.
http://www.mcbbs.net/thread-142335-1-1.html
GNU General Public License v3.0
54 stars 6 forks source link

Versioning - #3

Closed dxNeil closed 7 years ago

dxNeil commented 7 years ago

When downloading from Mojang, CurseCDN and BCML,

It gives me errors because it doesn't download properly. Incomplete handshakes.

HCMLSoft is the only source that works. It is not updated to 1.11.0/1.11.2.

huanghongxun commented 7 years ago

please update to 2.6

dxNeil commented 7 years ago

Thanks for getting back to me huanghongxun,

I have cloned it, and imported your project with gradle on Eclipse. Is it possible that we can update our launcher code so it supports 2.6 and those sources and 1.11.x works?

Do you have a donation address? We would like to donate to you once our launcher gets up and running (over 300K downloaders in our community!)

huanghongxun commented 7 years ago

Now I even doubt that where you are from... It's quite clear that you are supposed to use Netbeans instead of Eclipse because I've used the swing designer, or you will not stand the code generated automatically. The donation address has been removed because of some reasons.

dxNeil commented 7 years ago

Ohh my bad, sorry. Will make the switch. Hopefully this alleviates the error.

I'd like to say thank you for creating this amazing launcher, it's truly one of a kind.

DMC Owner,

Neil (1za)


From: huanghongxun notifications@github.com Sent: Monday, 23 January 2017 5:10:09 AM To: huanghongxun/HMCL Cc: dxNeil; Author Subject: Re: [huanghongxun/HMCL] Versioning - (#3)

Now I even doubt that where you are from... It's quite clear that you are supposed to use Netbeans instead of Eclipse because I've used the swing designer, or you will not stand the code generated automatically. The donation address has been removed because of some reasons.

- You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/huanghongxun/HMCL/issues/3#issuecomment-274401853, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AXy79YPWyIM7ecPtusS5IUmQ1vszp5sNks5rVDYxgaJpZM4LqipN.

dxNeil commented 7 years ago

Please, it doesn't work on Netbeans, gradle errors.

Eclipse, it can run perfectly.

How to update the code to 2.6?

dxNeil commented 7 years ago

NetBeans Gradle Errors:

"Issue 1

"
dxNeil commented 7 years ago

If you help me get 2.6 into eclipse, and if it downloads ALL update from mojang perfectly, I will pay you 300+ CNY (Chinese currency) through bitcoin or paypal.

Please if you help, I'll be grateful :)

huanghongxun commented 7 years ago

It seems that your gradle installation is broken. Clean up your environment and just install Netbeans and then its plugin Gradle Support(this plugin will automatically install gradle). A brand new env. should work. There's nothing special to the code.

dxNeil commented 7 years ago

I have deleted the netbeans projects, reinstalled netbeans, and installed Gradle support -

Issue 1

huanghongxun commented 7 years ago

It seems that there are some compilation errors. show the screenshot when you click the build button.

dxNeil commented 7 years ago

image image

huanghongxun commented 7 years ago

now please pull and retry.

dxNeil commented 7 years ago

Yes sir, I will do it right now and let you know immediately

dxNeil commented 7 years ago

Thank you very much. It works beautifully. I hope to see you soon, let me know when you open BTC donations.

Sincerely,

The DeviantsMC Team (http://deviantsmc.com)

huanghongxun commented 7 years ago

Donation address, paypal huanghongxun2008@126.com

dxNeil commented 7 years ago

Hi I prefer to use BTC because of privacy reasons, do you have a BTC address?

I don't think the assets download properly though from Mojang. Thanks anyways for helping

image

huanghongxun commented 7 years ago

Fixed in a recent commit. Because Mojang closed SSL channel to asset download site.

dxNeil commented 7 years ago

Hi, thanks we've updated our code base.

We will donate 70CNY tomorrow (Australian time) for your good work.

Just wondering though, when downloading from Mojang, it always gets stuck at 99- 6/7 jobs will never complete. Do you know why?

Picture #1 - http://prnt.sc/e0ibbz Picture #2 - http://prnt.sc/e0i6k8 Picture #3 - http://prnt.sc/e0i5n4

huanghongxun commented 7 years ago

It would be a network problem? So it finally failed because time limit exceeded? Here it could finish all downloads. Please try to copy links and download them by web browser to check if it's really network problem.

dxNeil commented 7 years ago

It works on web browser. The internet is good, and fast. I have tried on BMCL as source, and it works.

dxNeil commented 7 years ago

This is one method I use to fix it, disposing the TaskWindow when the percentage hits 99

image

But it is very dangerous... If a new version is installed/other mod is installed it might cause a corruption, right?

dxNeil commented 7 years ago

Can you put up a donation page? Or a paypal link for me to donate with my card? (I don't use paypal) I have a card

huanghongxun commented 7 years ago

Those download jobs which cannot finish may not be ignored. And when downloading libraries, and the progress reach 99%, and the last download job could finish, your code will break the downloading and cause game crashed because the libraries are not complete. Please see the stacktrace when those tasks(in the screenshots you gave) failed.

dxNeil commented 7 years ago

There is no stack trace. It doesn't say failed. It just stays on 99% and PGS = ??? for ever.

image

huanghongxun commented 7 years ago

So none of them failed?

huanghongxun commented 7 years ago

And could you check the lang file(https://github.com/huanghongxun/HMCL/blob/master/HMCUtils/src/main/resources/org/jackhuang/hellominecraft/lang/I18N_en.lang)? I think there are a great number of grammar and spelling mistakes.

And I found it difficult to create a paypal donation link and BTC link because of their authentication.

dxNeil commented 7 years ago

None failed.

No stacktrace or error or any fail in console.

For example: resource /50/50a59a.... is a task that is executed, but not finished not failed. Just idle

dxNeil commented 7 years ago

Okay no problem. I will get around to donate to you soon. I run a bitcoin mining pool. I will cash out and convert it to your paypal instead during the monthly pay date.

I'll check the language file.

huanghongxun commented 7 years ago

And when you use other minecraft launchers would this problem arise again? Chinese network should be worse than Australian.

dxNeil commented 7 years ago

This issue doesn't occur on other launchers. The official launcher works along with other cracked launchers such as TerraminingMC, TeamExtreme, Shiginima.

It is downloading from Mojang, so there shouldn't be a problem since they have servers in all countries, right?

dxNeil commented 7 years ago

I submitted a pull request for the English translation.

Someone from the DeviantsMC community generously translated the English version to his language Vietnamese - http://pastebin.com/R8Qp7sXc, you can use it if you want to.

I can also get a German (Deutsch) translation for you if you want.

huanghongxun commented 7 years ago

As for language files, plenty is no plague. I don't know it will be improved if I adds con.setReadTimeout(15000);

dxNeil commented 7 years ago

Hmm, we could test that out. Let me know where to add that

huanghongxun commented 7 years ago

FileDownloadTask.java add it after setConnectTimeout

dxNeil commented 7 years ago

Okay I will try it and tell you what happens

dxNeil commented 7 years ago

image

still image

huanghongxun commented 7 years ago

I found these files are all larger than 1 megabyte. It must be the problem. I haven't got it now. But the time limit should be less than 5 sec.

huanghongxun commented 7 years ago

Please set a breakpoint at FileDownloadTask: url.openConnection and step in each line and check which line blocks downloading.

dxNeil commented 7 years ago

image

Breakpoint set at every line on url.openConnection

huanghongxun commented 7 years ago

You should click "Debug" Button(or Ctrl+F5) to get into debug mode.

huanghongxun commented 7 years ago

And you should delete CrashReporter.java to stop your app send crash report to my server.

dxNeil commented 7 years ago

I emptied the reportToServer method image

Nothing diagnosed to far

image

huanghongxun commented 7 years ago

So you set some breakpoints and run the app and the application even not run to these places?incredible... test TaskList?

You should keep breakpoints enabled when app run from beginning to end. And you needn't clean up folder assets each time when debugging, just let these unfinished tasks do. Maybe you enable these breakpoints after the progress reached 99%?

dxNeil commented 7 years ago

First test, I ran from start to finish.

Second test I enabled breakpoints 98.

Do you think changing the buffersize array will fix this? I think it won't because I set it to double and it didn't do a thing.

Anyway,

I have tested TaskList image

It just stops at 99.

Another image: image

also

I did this one again: ![Uploading image.png…]()

huanghongxun commented 7 years ago

Anyway, do you keep these breakpoints enabled from start to finish? Whatever the problem is, It should run to FileDownloadTask.executeTask(). I guess you enable these breakpoints after these tasks idled.

Or it may be a nasty problem and I may not solve it.......

dxNeil commented 7 years ago

If I keep the break points from start to finish, it would take many, possibly thousands of clicks on the green button right to get from start to finish, right?

huanghongxun commented 7 years ago

No, when you start a new test, you need not clean up assets folder, just let these unfinished tasks do. When you retry download assets, these unfinished tasks will be executed again. So when application first paused, it would be the unfinished task's FileDownloadTask.


Things I mentioned above is better than that below.

Or you could make a trick, add codes like this:

if (url.endsWith("xxxxx")) {
System.out.println(); // make a breakpoint here.
}

make xxxxx the unfinished asset file name like: 4f8c3f9b4f290f63c78bf3bbaad16906a3ccff29

dxNeil commented 7 years ago

Yeah, that's what I've been doing. I delete other folders like libraries, but I keep 'assets' because I want it to start downloading from there.

I will try your new trick solution.

dxNeil commented 7 years ago

Is this correct?

image

huanghongxun commented 7 years ago

Yes. And it seems the connection has been successfully created. please click 'step over' button to run by each line. and see which line block the app.

But I think it may not happen if reading bytes blocks app.