search

Infisical / infisical-python

♾ Official Infisical SDK for Python
https://infisical.com/
MIT License
32 stars 8 forks source link

[Infra] Bump to Pydantic v2 #58

Open philipk19238 opened 9 months ago

philipk19238 commented 9 months ago
DanielHougaard commented 9 months ago

Hi Philip 👋

What was the reason for this bump? And can you please request a review from me on the PR? :-)

philipk19238 commented 9 months ago

Hi Daniel!

Pydantic v2 introduced many breaking changes that result in Infisical being not compatible with the current versions. This PR has to be made in order to use Infisical with any repo that uses Pydantic versions > 2.

DanielHougaard commented 9 months ago

Gotcha! And with this version bump, the SDK will remain back-compatible with projects running older versions of Pydantic?

philipk19238 commented 9 months ago

Gotcha! And with this version bump, the SDK will remain back-compatible with projects running older versions of Pydantic?

It should, since its just setting a default None value for Optional fields. Would just have to relax the pydantic version in pyproject.toml

DanielHougaard commented 9 months ago

It should, since its just setting a default None value for Optional fields. Would just have to relax the pydantic version in pyproject.toml

Cool! If you could please test on older versions of Pydanic just to make sure, that would be great. I'll also have a look in a bit myself :-)

Additionally, please remove the log.txt file from your PR 🙌

DanielHougaard commented 9 months ago

Hey @philipk19238, just following up on this!