Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
15.18k stars 880 forks source link

[ENG-136] Issues with google sso #1035

Open markksuite opened 1 year ago

markksuite commented 1 year ago

Using latest version of infisical frontend and backend (v.0.36.2) + mongo + redis, self hosted.

When pressing "Continue with Google" button (during login procs.), infisical redirects me to: https://subdomain.mydomain.com/api/v1/sso/subdomain.mydomain.com/login/sso?token=sometokenhere.

And shows blank json response: image

But, after I edit first part of url and delete subdomain.mydomain.com/api/v1/sso/ at the beginning of generated url (new address: https://subdomain.mydomain.com/login/sso?token=sometokenhere): image

Infisical succesfully accepts my auth request.

I think, in self-hosted solution, app just uses $SITE_URL environmental variable twice.

ENG-136

markksuite commented 1 year ago

Edited description (added more info) and issue title

dangtony98 commented 1 year ago

Hey @markksuite,

I assume you've followed each step in the docs for Google SSO here?

I would look into the redirect URL set in GCP as well as the SITE_URL environment variable being set in your instance of Infisical.

markksuite commented 1 year ago

@dangtony98 yes, and it works, if i remove the repeated url address

markksuite commented 1 year ago

env Here is my env vars (running in kube, v.0.36.2 docker image)

markksuite commented 1 year ago

Google api: env2

dangtony98 commented 1 year ago

Awesome so we can consider this issue resolved? @markksuite

markksuite commented 1 year ago

I still have the same issue, url is repeated twice (it works only if you manually edit url link, in browser)

markksuite commented 1 year ago

Sorry, forget about tagging, almost every time :). @dangtony98