search

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
13k stars 677 forks source link

[ENG-146] App throws Application error #1046

Open techemmy opened 9 months ago

techemmy commented 9 months ago

Describe the bug

I invited a new user to an organization as an admin. In the same browser in a new tab, I received the invite I sent (I have access to the new user email). In the new user account on the members section, the Add to projects button shows beside the new user's email (which I think should show for only admins). I clicked the button which threw the Application error prompt. I refreshed the page hoping it was because I was just logged in as an admin before accepting the invite, but the button was still there. I tried logging in to the Member account on a different browser, but t still shows the same button.

To Reproduce

Steps to reproduce the behaviour:

  1. Log in as an admin and invite a new member
  2. Accept the member invite on the same browser
  3. Go to the Members tab
  4. You should see the Add to projects button there even if you refresh.

Expected behaviour

I don't think the Add to projects button should show for just Members.

Screenshots

Screenshot 2023-10-02 at 23 20 52 Screenshot 2023-10-02 at 23 23 25

Platform you are having the issue on:

On app.infisical.com

ENG-146

Salman2301 commented 9 months ago

Able to replicate the issue. The better fix is not letting the user to login. If user is already loggedIn

It happens in the /signupInvite page allowing a loggedIn user to register via an invite.

2. Accept the member invite on the same browser

It's actually a frontend issue.

techemmy commented 9 months ago

Well done @Salman2301 🙌