[ENG-211] Vercel Integration doesn't have preview main branch

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI

https://infisical.com

Other

14.94k stars 839 forks source link

[ENG-211] Vercel Integration doesn't have preview main branch #1133

Open AlexXi19 opened 10 months ago

AlexXi19 commented 10 months ago

Describe the bug

We’re using the vercel integration and our main brach is our staging environment. However, the main branch doesn’t show up on the vercel preview branch optional dropdown selection

To Reproduce

Steps to reproduce the behavior:

Go to the dashboard, create a vercel integration, select select vercel preview, look in the dropdown menu

Expected behavior

Should see the main branch

Screenshots

Additional context

Slack conversation: https://infisical-users.slack.com/archives/C04BSBMQAQ7/p1698428850417039

_ENG-211

DanielHougaard commented 8 months ago

Hi Alex! This is actually intended behavior. As you can see here we filter out the main branch for the preview environment.

How come you want to use the main branch on your preview environment?

AlexXi19 commented 8 months ago

@DanielHougaard Hey Daniel, thanks for replying. We do periodic releases to our users by merging our main branch into a prod branch instead of using main as the production branch, it would technically be more accurate to change the default branch to staging for our case but we just decided to go with main. So for us, merging into main = merging into the beta / staging environment.