Add input validation for text field

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI

https://infisical.com

Other

13.16k stars 698 forks source link

Add input validation for text field #1421

Open teyim opened 5 months ago

teyim commented 5 months ago

Describe the bug

Input fields allow users to input very lengthy strings, causing the UI of the application to break

To Reproduce

Steps to reproduce the behavior:

input very long text when adding new name and organisation name on signup or project name in user dashboard

Expected behavior

The input validation should restrict the number of characters I put in the input field.

Screenshots

Screenshot from 2024-02-18 16-38-16

Platform you are having the issue on:

Infisical webapp

Additional context

Add any other context about the problem here.

tanvirraj commented 5 months ago

@akhilmhdh, you can assign it to me,

add a context what you guys think max length

teyim commented 5 months ago

i was thinking 16 characters would be good.

vmatsiiako commented 5 months ago

16 characters is probably too little. I would think 64?

Salman2301 commented 4 months ago

@tanvirraj opened a PR that ~partial~ fix this issue. If you are still busy with input validation let me know. Or I can add the validation on the above mention PR together cc: @vmatsiiako

tanvirraj commented 4 months ago

hey @Salman2301, i will do this in my next weekend

Salman2301 commented 4 months ago

@vmatsiiako this can be closed