search

Infisical / infisical

♾ Infisical is the open-source secret management platform: Sync secrets across your team/infrastructure, prevent secret leaks, and manage internal PKI
https://infisical.com
Other
15.17k stars 879 forks source link

Automatically validate the email verification code (no need to press <ENTER>) #1582

Open Grraahaam opened 6 months ago

Grraahaam commented 6 months ago

Feature description

Today, when I create an account, I'm receiving the verification code to sign in by email. I then need to copy and paste it in the app, after what I need to press ENTER or the submit button.

  1. We could validate the code directly when pasting it in the input, or once all the fields have been populated?
  2. I've seen a topic somewhere here about replacing the verification code by a link to simplify this process

What do you think?

Why would it be useful?

It'd improve the UX and simplify the user's verification process

Additional context

Related issues:

kavinda1995 commented 6 months ago

@Grraahaam I can work on this issue if anyone else is not working currently

DanielHougaard commented 6 months ago

I agree, we could improve the UX by letting it automatically continue after pasting the full code.

@kavinda1995 Yes! That would be awesome!

Grraahaam commented 6 months ago

@DanielHougaard This change doesnt change the validation logic itself, so it's easy to implement and will already help.

But I think that the verification link would be an even better idea in the long term (e.g. code already in the URL) as it'll make the verification step even faster and less prone to error for people who wrongly copy/pasted the code from the mail for example (e.g. missing digits or mail formatting issues), but the logic might need to be updated in this case.

WDYT?

DanielHougaard commented 6 months ago

@Grraahaam I agree, that would be even better. I wouldn't start doing that just yet though. We need to make the emails nicer in general at some point, and I think such a change would fall pretty nicely into that scope.

For now I think making it automatically continue efter entering the code is the right move!

Grraahaam commented 6 months ago

For now I think making it automatically continue efter entering the code is the right move!

Absolutely!

We need to make the emails nicer in general at some point, and I think such a change would fall pretty nicely into that scope.

Actually I've started an email branding branch a while ago (https://github.com/Infisical/infisical/pull/444), but didn't took time to migrate it to https://github.com/resendlabs/react-email

DanielHougaard commented 6 months ago

Oh wow I didn't see that one, awesome! React email is great, and this is actually what I had in mind for the mail refactor. Currently it's not a huge priority, but it will defiantly become a more pressing topic in the future.

vishavsingla commented 6 months ago

Is this issue resolved?

Grraahaam commented 6 months ago

Hey @vishavsingla ! Doesnt seems to be..

@kavinda1995 was willing to work on it

siddhant-agrawal01 commented 3 months ago

Is the issue resolved?

akshat99812 commented 3 months ago

I'll take this if it's available

rahuljagtapp commented 2 months ago

@Grraahaam I can work on this issue if issue is open